Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest file #7

Merged
merged 13 commits into from
Jul 17, 2024
Merged

Manifest file #7

merged 13 commits into from
Jul 17, 2024

Conversation

gentlementlegen
Copy link
Member

Depends on #1
Relates to ubiquity-os/ubiquity-os-kernel#71

@gentlementlegen gentlementlegen changed the title Manifest Manifest file Jul 11, 2024
@github-actions GitHub Actions
Copy link

Unused files (2)

src/main.ts, src/plugin.ts

Unused dependencies (2)

Filename dependencies
package.json @actions/core
@actions/github

Unused exports (1)

Filename exports
src/types/plugin-input.ts startStopSettingsValidator

Unused types (1)

Filename types
src/types/plugin-input.ts PluginInputs

@gentlementlegen gentlementlegen changed the base branch from development to main July 15, 2024 06:38
@gentlementlegen gentlementlegen changed the base branch from main to development July 15, 2024 06:38
@gentlementlegen gentlementlegen marked this pull request as ready for review July 15, 2024 06:40
0x4007
0x4007 reviewed Jul 16, 2024
View reviewed changes
manifest.json Outdated Show resolved Hide resolved
0x4007
0x4007 requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the files view. There's some unused types.

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jul 16, 2024 •
edited
Loading

Check the files view. There's some unused types.

I think these are false positives by Knip. startStopSettingsValidator is used here and PluginInputs there.

Nevermind I think I know why this happens, will fix.

@gentlementlegen
Copy link
Member Author

@0x4007 I fixed workflows, everything will be green after this is merged to development.

@gentlementlegen gentlementlegen merged commit b3045c3 into ubiquity-os-marketplace:development Jul 17, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gentlementlegen @0x4007